Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add executable flag to grub_file_check.sh (bugfix) #924

Merged
merged 1 commit into from
Jan 10, 2024

Conversation

pseudocc
Copy link
Contributor

Fix for commit bc84c03

Description

Correct the file mode (644 -> 755).

Resolved issues

dpkg -L checkbox-provider-base | grep grub_file_check.sh

grub_file_check.sh is missing from debian package checkbox-provider-base.

Documentation

Tests

Copy link

codecov bot commented Jan 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (941f021) 37.13% compared to head (5d3f1e9) 37.13%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #924   +/-   ##
=======================================
  Coverage   37.13%   37.13%           
=======================================
  Files         313      313           
  Lines       34806    34806           
  Branches     5982     5982           
=======================================
  Hits        12925    12925           
  Misses      21308    21308           
  Partials      573      573           
Flag Coverage Δ
provider-base 5.99% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@pieqq pieqq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@pieqq pieqq changed the title fix(provider-base): file mode missing "x" flag grub_file_check.sh missing executable flag (bugfix) Jan 10, 2024
@pieqq pieqq changed the title grub_file_check.sh missing executable flag (bugfix) Fix grub_file_check.sh missing executable flag (bugfix) Jan 10, 2024
@pieqq pieqq changed the title Fix grub_file_check.sh missing executable flag (bugfix) Add executable flag to grub_file_check.sh (bugfix) Jan 10, 2024
@pieqq pieqq merged commit e5349d7 into canonical:main Jan 10, 2024
9 of 13 checks passed
LiaoU3 pushed a commit to LiaoU3/checkbox that referenced this pull request Mar 20, 2024
fix(provider-base): file mode missing "x" flag

Fix for commit bc84c03
binli pushed a commit to binli/checkbox that referenced this pull request Mar 22, 2024
fix(provider-base): file mode missing "x" flag

Fix for commit bc84c03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants