Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add realtime performance test (New) #925

Merged
merged 6 commits into from
Mar 22, 2024

Conversation

LiaoU3
Copy link
Contributor

@LiaoU3 LiaoU3 commented Jan 10, 2024

Description

I move the realtime performance test from checkbox-iiotg-provider to the checkbox monorepo.

Resolved issues

N/A

Documentation

N/A

Tests

I run testplan rt-performance-tests-full or you can say Realtime Peformance Tests (Full) on EHL (202306-31656).
submission: https://certification.canonical.com/hardware/202306-31656/submission/351345/

Copy link

codecov bot commented Jan 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 41.72%. Comparing base (604d369) to head (6b30454).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #925      +/-   ##
==========================================
+ Coverage   41.64%   41.72%   +0.07%     
==========================================
  Files         340      341       +1     
  Lines       37748    37795      +47     
  Branches     6419     6426       +7     
==========================================
+ Hits        15722    15769      +47     
  Misses      21378    21378              
  Partials      648      648              
Flag Coverage Δ
provider-base 15.25% <100.00%> (+0.26%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@LiaoU3 LiaoU3 marked this pull request as ready for review February 22, 2024 00:58
Copy link
Collaborator

@pieqq pieqq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job on the script and the associated unit tests!

Two little suggestions (you can apply them directly from GitHub) and one question.

providers/base/tests/test_run_cyclictest.py Outdated Show resolved Hide resolved
providers/base/units/rt-performance-tests/category.pxu Outdated Show resolved Hide resolved
@LiaoU3
Copy link
Contributor Author

LiaoU3 commented Mar 15, 2024

@pieqq Please review it again when you have time.

@LiaoU3 LiaoU3 requested a review from pieqq March 18, 2024 09:04
Copy link
Collaborator

@pieqq pieqq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add the packaging metadata and snapcraft.yaml addition as discussed in my comment.

@LiaoU3 LiaoU3 requested review from pieqq and kissiel March 20, 2024 10:32
Copy link
Collaborator

@pieqq pieqq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Packaging bits look good, just one thing to add back into the script.

providers/base/bin/run_cyclictest.py Show resolved Hide resolved
pieqq
pieqq previously approved these changes Mar 21, 2024
@pieqq pieqq enabled auto-merge (squash) March 21, 2024 09:11
@pieqq pieqq disabled auto-merge March 21, 2024 09:18
Copy link
Collaborator

@pieqq pieqq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, thanks!

@pieqq pieqq merged commit 48f984a into canonical:main Mar 22, 2024
12 checks passed
binli pushed a commit to binli/checkbox that referenced this pull request Mar 22, 2024
* Add realtime performance test

* Add rt-tests into stage-packages for series22

* Add packaging.pxu for rt-tests

---------

Co-authored-by: Pierre Equoy <pierre.equoy@canonical.com>
@LiaoU3 LiaoU3 deleted the migrate_iotg_realtime branch April 2, 2024 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants