-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(24.04): add finalrd and add bins slice to libc-bin #342
base: ubuntu-24.04
Are you sure you want to change the base?
Conversation
Diff of dependencies: slices/finalrd.yaml@@ -0,0 +1,5 @@
+coreutils
+grep
+libc-bin
+mount
+systemd slices/libc-bin.yaml@@ -1 +1,2 @@
+dash
libc6 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a difficult slice to test. I'll ask around our team and see if anyone has an additional strategy. Other than that I only have the one question below.
Thanks! :)
# findutils and debianutils. so rely on atleast the first set of binaries. | ||
bins: | ||
essential: | ||
- coreutils_bins |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since this is a shell script should we add dash_bins
for the shell and base-files_bin
for /bin
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you probably don't need the entire coreutils
, so I suggest creating a new coreutils slice(s) with just the bins you need for this.
@@ -4,6 +4,33 @@ essential: | |||
- libc-bin_copyright | |||
|
|||
slices: | |||
bins: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need tests for this
# findutils and debianutils. so rely on atleast the first set of binaries. | ||
bins: | ||
essential: | ||
- coreutils_bins |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you probably don't need the entire coreutils
, so I suggest creating a new coreutils slice(s) with just the bins you need for this.
Proposed changes
Finalrd is needed by Ubuntu Core - added the package and extended libc-bin by adding the binaries it carries. Those are needed not only by the finalrd script (which invokes ldconfig), but also by our hooks in ubuntu core.
I added a test for finalrd, but as expected it will fail, so we just ensure it fails in the way we expect.
Checklist