-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(24.04): add python3 slice #387
base: ubuntu-24.04
Are you sure you want to change the base?
Conversation
Diff of dependencies: slices/python3.yaml@@ -1,3 +1 @@
-libpython3-stdlib
-python3-minimal
python3.12 |
essential: | ||
- python3.12_utils | ||
contents: | ||
/usr/bin/pdb3: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do these files need to be symlinked to their python 3.12 alternatives in python3.12_utils?
ex. /usr/bin/pdb3 -> /usr/bin/pdb3.12
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
They are already symlinks when installed from python3 package, and they are linked properly (pdb3 linked to pdb3.12, etc).
essential: | ||
- python3_copyright | ||
|
||
slices: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we modify or add a slice to link python3.12 to python3 and possibly python? Previously we would let the user link these, but If the user is simply including the python3 slice, it may prevent some confusion when migrating between python versions in different releases.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A link from python to python3.12 is not created by the postinst script of python3 package, so I didn't include that in this slice. Besides, linking python3 to a specific python3.x version will cause conflicts when there are multiple python3.x packages in the same release (e.g. python3.10 and python3.11 in 22.04).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM Thanks!
Proposed changes
Add python3 slice, which depends on python3.12 slices and add a couple of symlinks over that.
Related issues/PRs
N/A
Forward porting
N/A
Checklist
Additional Context
N/A