Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(24.04): add SDF for vim.tiny #490

Open
wants to merge 8 commits into
base: ubuntu-24.04
Choose a base branch
from

Conversation

eunufe
Copy link

@eunufe eunufe commented Feb 10, 2025

Proposed changes

feat(24.04): add SDF for vim.tiny

Related issues/PRs

Forward porting

#491

Checklist

Additional Context

Copy link

Diff of dependencies:
None found.


@eunufe eunufe mentioned this pull request Feb 10, 2025
3 tasks
Copy link
Collaborator

@zhijie-yang zhijie-yang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks overall good to me. Just have a nitpick, other opinions are welcomed.

slices/vim-common.yaml Show resolved Hide resolved
@rebornplusplus rebornplusplus self-assigned this Feb 13, 2025
Copy link
Member

@rebornplusplus rebornplusplus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks nice to me, just one tiny comment following @zhijie-yang's earlier comments.

slices/vim-tiny.yaml Show resolved Hide resolved
Copy link
Collaborator

@cjdcordeiro cjdcordeiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks. I'd just apply the nitpick raised by @rebornplusplus and then it would be good to go

slices/vim-tiny.yaml Show resolved Hide resolved
@eunufe
Copy link
Author

eunufe commented Feb 18, 2025

@rebornplusplus, @cjdcordeiro since the ci: bump to cla check : 9306048

My cla checks have been failing, please investigate. Thank you!!

@rebornplusplus
Copy link
Member

@rebornplusplus, @cjdcordeiro since the ci: bump to cla check : 9306048

My cla checks have been failing, please investigate. Thank you!!

Sigh. :( No worries about that, I will reach out to the appropriate folks.

@cjdcordeiro
Copy link
Collaborator

@rebornplusplus, @cjdcordeiro since the ci: bump to cla check : 9306048
My cla checks have been failing, please investigate. Thank you!!

Sigh. :( No worries about that, I will reach out to the appropriate folks.

Indeed, a recent update of the GH actions seems to have introduced some regressions. We can still bypass that since you already committed before and we can see you in the CLA list

@rebornplusplus
Copy link
Member

rebornplusplus commented Feb 19, 2025

Hi @eunufe, the simplest way to ignore future failed workflow runs would be to sign the CLA again. I am guessing your username/email has not been carried over to the new database for some reason.

Could you please sign the CLA form again and let me know? I will re-trigger the CI afterwards. Sorry for the trouble.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants