-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(24.04): add SDF for vim.tiny #490
base: ubuntu-24.04
Are you sure you want to change the base?
Conversation
Diff of dependencies: |
602a002
to
7e3c50e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks overall good to me. Just have a nitpick, other opinions are welcomed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks nice to me, just one tiny comment following @zhijie-yang's earlier comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks. I'd just apply the nitpick raised by @rebornplusplus and then it would be good to go
@rebornplusplus, @cjdcordeiro since the ci: bump to cla check : 9306048 My cla checks have been failing, please investigate. Thank you!! |
Sigh. :( No worries about that, I will reach out to the appropriate folks. |
Indeed, a recent update of the GH actions seems to have introduced some regressions. We can still bypass that since you already committed before and we can see you in the CLA list |
Hi @eunufe, the simplest way to ignore future failed workflow runs would be to sign the CLA again. I am guessing your username/email has not been carried over to the new database for some reason. Could you please sign the CLA form again and let me know? I will re-trigger the CI afterwards. Sorry for the trouble. |
Proposed changes
feat(24.04): add SDF for vim.tiny
Related issues/PRs
Forward porting
#491
Checklist
Additional Context