chore: create and attach binaries on tag, release

[rebornplusplus]

Requires #90.
(This PR includes commit 3e4ec0b from #90.)

Create binaries on push, tag creation and when a release has been published. Create an archive with the binary, and attach it to the release if a release is published. Attach the archive in the workflow run as an artifact in all cases.

The actions/checkout@v3 action overwrites annotated tag with lightweight tags breaking git describe. See [1], [2]. This commit adds a workaround to restore the latest tag to it's original state.

References:

1. checkout overwrites tags with lightweight tags actions/checkout#882
2. Preserve tag annotations actions/checkout#290

---

• Have you signed the CLA?

[rebornplusplus]

/cc @cjdcordeiro @woky @niemeyer

[rebornplusplus]

Note: due to the nature of how the version is generated in Chisel right now (parsing from git describe --always output), new tags should be annotated.

[cjdcordeiro]

nice. looks clean and aligned with Pebble's workflows.

Do you have an example of a successful run?

Wrt the lightweight tags: what if a release is created from a lightweight tag? wouldn't this try to attach the binaries to the wrong release?

[rebornplusplus]

Do you have an example of a successful run?

This is the test release on my fork: https://github.com/rebornplusplus/chisel/releases/tag/v1.0.1 (Notice the attached tarballs)
And the relevant workflow run: https://github.com/rebornplusplus/chisel/actions/runs/5747732205

Wrt the lightweight tags: what if a release is created from a lightweight tag? wouldn't this try to attach the binaries to the wrong release?

So if a release is published with lightweight tags, mkversion.sh as it is right now, will not pick up on the lightweight tags.

        v="$(git describe --always | sed -e 's/-/+git/;y/-/./' )"

To allow lightweight tags to contribute to version determination, we will need to pass the --tags option to git describe above. It's a simple fix. Let me know if you want me to include it in this PR.

[cjdcordeiro]

Thanks for the details @rebornplusplus!

Alright, so wrt the lightweight tags, that seems to be what we also do in Pebble -> https://github.com/canonical/pebble/blob/f5938105cb2611c7753f63beff5c71373ff0612b/cmd/mkversion.sh#L46

Unless you see a good reason why we should avoid releases that are based on lightweight tags, I think it would be safer to just add --tags to the version determination.

[rebornplusplus]

Unless you see a good reason why we should avoid releases that are based on lightweight tags, I think it would be safer to just add --tags to the version determination.

Sounds good. I have updated it in c272db4. Please take another look.

[cjdcordeiro]

great, thanks ;)

[jnsgruk]

One comment that could make things a little easier to read. Let me know, this is pretty much ready to go.

[rebornplusplus]

I have rebased the commits of this PR on the updated main branch since #90 is merged already. The only change is that 3e4ec0b was dropped from this PR as the changes in that commit are merged already. Sorry for any inconveniences.