Add pub_key_ed25519 to cc_phone_home

[dhensby]

Initial pass at adding the ed25519 host key to allowed phone_home payload keys.

LP: #1866671

[dhensby]

Hi team!

This is my first pass at adding this to phone_home; I'm not sure if there are tests for this feature or what else is required. Happy to improve the PR following any pointers and/or guidance.

Thanks

[OddBloke]

Hi @dhensby, thanks for the contribution! This looks good to me.

There aren't any tests for cc_phone_home currently, but we would love it if you could contribute some. Is that something that you'd be interested in doing? (Either way, given that they don't currently exist, landing this PR is not contingent on you doing so!)

[dhensby]

Hey @OddBloke. I'm afraid my python knowledge is pretty limited so writing a test for this is something that's going to be quite a bit out of my domain of knowledge 😳

[OddBloke]

Thanks!

[OddBloke]

So this branch is ready to land, but as you can see our "cla-validate" check is failing. This failure is not because of anything you've done, @dhensby, but because we need to fix something up in that check. I'm going to leave this unmerged until #244 lands, so that we have a non-synthetic test case to look at.

(I'm marking this "Request changes" only so we don't accidentally merge this. It is ready to land.)

[OddBloke]

OK, the CLA fix has landed and is working, so we can land this once CI has passed. (Thanks for putting up with this noise!)

[OddBloke]

(For future reference, we squash-merge into master, so maintaining a clean commit history in your PR branch isn't necessary. But I appreciate the effort! 👍)

[dhensby]

Thanks for getting this in. Just for my reference what is the kind of timeline we can expect for something like this to start making its way into a release and onto servers?

[OddBloke]

Thanks for getting this in. Just for my reference what is the kind of timeline we can expect for something like this to start making its way into a release

The next cloud-init release will be 20.2. We don't have a set release date for it, but you can expect it sometime in Q2.

and onto servers?

That rather depends on what distribution you're using. For Ubuntu, we regularly backport upstream snapshots to all stable releases (i.e. 16.04 and later), and I would expect that next to happen soon after focal's release towards the end of April. (As these are snapshots, you wouldn't be waiting for 20.2 to drop.) Once backported, it would make its way into the official Ubuntu cloud images, and then onto servers deployed from them.

(I can't speak with authority for any other distributions, but if you give me a specific one then I can ask around.)

[dhensby]

That's great, about all I need to know. It's not an essential need for us but just good to know. Thanks