Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

workflows/cla.yml: use correct username for CLA check #243

Merged
merged 2 commits into from
Mar 11, 2020

Conversation

OddBloke
Copy link
Collaborator

Instead of using the username that triggered the action (which, in the
case of a committer merging master into a PR branch will be the
committer), always use the username of the submitter of the pull
request.

Instead of using the username that triggered the action (which, in the
case of a committer merging master into a PR branch will be the
committer), always use the username of the submitter of the pull
request.
@OddBloke
Copy link
Collaborator Author

For reviewers:

I have tested in my personal branch that this works for the trivial case (so we at least aren't regressing with this change): https://github.com/OddBloke/cloud-init/actions/runs/53241094/workflow

@blackboxsw blackboxsw self-assigned this Mar 10, 2020
Copy link
Collaborator

@blackboxsw blackboxsw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the extra doc links for context.

@blackboxsw blackboxsw merged commit a4d64e2 into canonical:master Mar 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants