Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cc_resolv_conf: introduce tests and stabilise output across Python versions #251

Merged
merged 2 commits into from
Mar 13, 2020

Conversation

OddBloke
Copy link
Collaborator

@OddBloke OddBloke commented Mar 12, 2020

This is a follow-up to #144 which fixed the rendering behaviour.

While writing the tests, CI failed due to dict iteration differences across Python versions, so this also sorts output so that we will produce the same output across Python versions.

@OddBloke
Copy link
Collaborator Author

OddBloke commented Mar 12, 2020 via email

@OddBloke OddBloke changed the title cloudinit/config/tests/test_resolv_conf: introduce rendering test cloudinit/config/cc_resolv_conf: introduce tests and stabilise output across Python versions Mar 13, 2020
@OddBloke OddBloke changed the title cloudinit/config/cc_resolv_conf: introduce tests and stabilise output across Python versions cc_resolv_conf: introduce tests and stabilise output across Python versions Mar 13, 2020
Copy link
Collaborator

@raharper raharper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Dan!

@OddBloke OddBloke merged commit 1426a0d into canonical:master Mar 13, 2020
@OddBloke OddBloke deleted the resolv_conf_fix branch March 13, 2020 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants