-
Notifications
You must be signed in to change notification settings - Fork 911
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
More unit test documentation #314
Merged
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
2871e61
HACKING.rst: add list of available pytest fixtures
OddBloke 77205dc
HACKING.rst: typo fix
OddBloke c053c6f
HACKING.rst: add missing newline
OddBloke a27b55b
HACKING.rst: capture common mock naming pattern in codebase
OddBloke 01b6941
HACKING.rst: fix stray punctuation
OddBloke 610618e
Merge branch 'master' into doc
OddBloke File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
unrelated: when are we gonna start testing with a newer LTS by default?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Travis already tests against the latest PyPI packages by default. So in one sense, we already do.
That said, the reason for this constraint is not our upstream CI testing, it's because we backport the latest cloud-init upstream to xenial, and the unit tests run as part of the package build. This is why Travis has a separate job to test against the xenial versions of our dependencies. So in another sense, the earliest LTS we want the tests (and cloud-init in general) to run on won't change until, at the earliest, xenial leaves standard support in April 2021.