Create tests to validate schema examples #348
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blackboxsw
approved these changes
May 6, 2020
There was a problem hiding this comment.
Good to have the additional fixes and this coverage to alert us to inconsistencies in schema docs.
I've hit the update branch button and will await CI before merging.
After this merges, I'll also manually update the related launchpad bug status to 'fix committed' and add a comment mentioning this specific upstream commit url.
| @@ -61,9 +61,9 @@ | |||
| snap: | |||
| assertions: | |||
| 00: | | |||
| signed_assertion_blob_here | |||
| signed_assertion_blob_here | |||
There was a problem hiding this comment.
Excellent @lucasmoura, I'm glad this caught an invalid test config Too! Proof of a job well done.
This was referenced May 12, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following this launchpad bug, we need to validate if the examples provided in the config module are conforming to the concatenated schema of all config modules. The rationale behind that is not only to verify if the examples are correctly written but to assert that no config schema is interfering with each other.
Also, but looking at the validate_cloudconfig_schema, I believe that will raise the
SchemaValidationErrorby usingstrict=True, so I have only called the function pasisng the right schemas to compare.LP: #1876412