HACKING.rst: guide people to add themselves to the CLA file #349
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheRealFalcon
approved these changes
May 9, 2020
HACKING.rst
Outdated
| @@ -57,11 +60,24 @@ Do these things once | |||
| * Read through the cloud-init `Code Review Process`_, so you understand | |||
| how your changes will end up in cloud-init's codebase. | |||
|
|
|||
| * Submit your first cloud-init pull request, adding yourself to the | |||
| in-repository list that we use to track CLA signatures: | |||
| ``tools/.github-cla-signers`` | |||
There was a problem hiding this comment.
nit: could link to the actual file here and on line 71, but obviously not necessary.
This (a) gives people an easy way of getting a commit into the codebase, and (b) saves us from having to explain this process (or do it ourselves) for every new contributor.
|
+1 to changes |
TheRealFalcon
approved these changes
May 11, 2020
blackboxsw
approved these changes
May 11, 2020
This was referenced May 12, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This (a) gives people an easy way of getting a commit into the codebase,
and (b) saves us from having to explain this process (or do it
ourselves) for every new contributor.