Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add "broadcast" to network v1 schema #5034

Merged
merged 1 commit into from
Mar 9, 2024

Conversation

TheRealFalcon
Copy link
Member

Proposed Commit Message

fix: Add "broadcast" to network v1 schema

Both the klibc initramfs code and the eni code will write a network v1
configuration including the broadcast address if it is provided. It
gets rendered if using the eni renderer.

LP: #2056460

Additional Context

https://bugs.launchpad.net/ubuntu/+source/cloud-init/+bug/2056460

Merge type

  • Squash merge using "Proposed Commit Message"
  • Rebase and merge unique commits. Requires commit messages per-commit each referencing the pull request number (#<PR_NUM>)

Both the klibc initramfs code and the eni code will write a network v1
configuration including the broadcast address if it is provided. It
gets rendered if using the eni renderer.

LP: #2056460
Copy link
Member

@holmanb holmanb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@blackboxsw blackboxsw merged commit c6f1e61 into canonical:main Mar 9, 2024
29 checks passed
holmanb pushed a commit to holmanb/cloud-init that referenced this pull request Mar 9, 2024
Both the klibc initramfs code and the eni code will write a network v1
configuration including the broadcast address if it is provided. It
gets rendered if using the eni renderer.

LP: #2056460
holmanb pushed a commit to holmanb/cloud-init that referenced this pull request Mar 9, 2024
Both the klibc initramfs code and the eni code will write a network v1
configuration including the broadcast address if it is provided. It
gets rendered if using the eni renderer.

LP: #2056460
@holmanb holmanb mentioned this pull request Mar 9, 2024
1 task
holmanb pushed a commit that referenced this pull request Mar 11, 2024
Both the klibc initramfs code and the eni code will write a network v1
configuration including the broadcast address if it is provided. It
gets rendered if using the eni renderer.

LP: #2056460
holmanb pushed a commit to holmanb/cloud-init that referenced this pull request Mar 12, 2024
Both the klibc initramfs code and the eni code will write a network v1
configuration including the broadcast address if it is provided. It
gets rendered if using the eni renderer.

LP: #2056460
holmanb pushed a commit that referenced this pull request Mar 12, 2024
Both the klibc initramfs code and the eni code will write a network v1
configuration including the broadcast address if it is provided. It
gets rendered if using the eni renderer.

LP: #2056460
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants