Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ca_certs): Add AlmaLinux OS and CloudLinux OS support #5264

Merged
merged 1 commit into from
May 9, 2024
Merged

feat(ca_certs): Add AlmaLinux OS and CloudLinux OS support #5264

merged 1 commit into from
May 9, 2024

Conversation

LKHN
Copy link
Contributor

@LKHN LKHN commented May 6, 2024

Proposed Commit Message

feat(ca_certs): Add AlmaLinux OS and CloudLinux OS support

AlmaLinux OS is binary compatible with RHEL
and CloudLinux OS based on AlmaLinux OS.
So, let's use distro-specific configurations from rhel.

Additional Context

This bugfix is part of a patch which is used in cloud-init packages of AlmaLinux OS 8 and 9.

Test Steps

User data:

#cloud-config
ca_certs:
  remove_defaults: true
  trusted:
    - single_line_cert
    - |
      -----BEGIN CERTIFICATE-----
      YOUR-ORGS-TRUSTED-CA-CERT-HERE
      -----END CERTIFICATE-----

Checklist

Merge type

  • Squash merge using "Proposed Commit Message"
  • Rebase and merge unique commits. Requires commit messages per-commit each referencing the pull request number (#<PR_NUM>)

@LKHN
feat(ca_certs): Add AlmaLinux OS and CloudLinux OS support
2f05e79 
AlmaLinux OS is binary compatible with RHEL
and CloudLinux OS based on AlmaLinux OS.
So, let's use distro-specific configurations from rhel.

Signed-off-by: Elkhan Mammadli <elkhan.mammadli@protonmail.com>
@LKHN LKHN mentioned this pull request May 6, 2024
Closed
TheRealFalcon
TheRealFalcon approved these changes May 9, 2024
View reviewed changes
Copy link
Member

@TheRealFalcon TheRealFalcon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks!

@TheRealFalcon TheRealFalcon merged commit 9388cc1 into canonical:main May 9, 2024
29 checks passed
holmanb pushed a commit that referenced this pull request Jun 28, 2024
@LKHN @holmanb
feat(ca_certs): Add AlmaLinux OS and CloudLinux OS support (#5264)
0d5dc81 
AlmaLinux OS is binary compatible with RHEL
and CloudLinux OS based on AlmaLinux OS.
So, let's use distro-specific configurations from rhel.

Signed-off-by: Elkhan Mammadli <elkhan.mammadli@protonmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TheRealFalcon TheRealFalcon TheRealFalcon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@LKHN @TheRealFalcon