azure: add PPS support for azure-proxy-agent #5601
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cjp256
approved these changes
Aug 9, 2024
There was a problem hiding this comment.
LGTM, thanks! I think @blackboxsw will like the new logs :D Unit tests need updating though.
blackboxsw
requested changes
Aug 15, 2024
There was a problem hiding this comment.
Thanks @KsenijaS for this PR and the improved logs are appreciated. Is there an existing unit test or new unit test we can extend that asserts we check azure proxy agent status in PPS when config is properly set? Then we can ensure we don't degrade this expected behavior in the future.
cjp256
reviewed
Aug 16, 2024
cjp256
approved these changes
Aug 16, 2024
|
LGTM! :) |
blackboxsw
approved these changes
Aug 27, 2024
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Commit Message
Additional Context
Test Steps
Merge type