Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(actions): add doc label for any doc related subdir file matches #5602

Merged
merged 1 commit into from
Aug 13, 2024

Conversation

blackboxsw
Copy link
Collaborator

Proposed Commit Message

chore(actions): add doc label for any doc related subdir file matches

Recently noticed that doc file changes in nested subdirs were not triggering documentation auto label.

Example of subdir match at
https://github.com/actions/labeler?tab=readme-ov-file#basic-examples

Additional Context

documentation PR that didn't auto-label
#5595

Test Steps

Merge type

  • Squash merge using "Proposed Commit Message"
  • Rebase and merge unique commits. Requires commit messages per-commit each referencing the pull request number (#<PR_NUM>)

Recently noticed that doc file changes in nested subdirs were
not triggering documentation auto label.

Example of subdir match at
https://github.com/actions/labeler?tab=readme-ov-file#basic-examples
@blackboxsw blackboxsw added the documentation This Pull Request changes documentation label Aug 10, 2024
Copy link
Member

@TheRealFalcon TheRealFalcon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as long as we're sure globstar is supported here.

@TheRealFalcon TheRealFalcon self-assigned this Aug 12, 2024
@blackboxsw blackboxsw merged commit 4c96055 into canonical:main Aug 13, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation This Pull Request changes documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants