Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable the sysv init scripts in OpenBSD build script #5790

Merged
merged 2 commits into from
Oct 21, 2024

Conversation

hcartiaux
Copy link
Contributor

@hcartiaux hcartiaux commented Oct 6, 2024

Proposed Commit Message

<type>fix(openbsd)</type>: Enable sysv init scripts in OpenBSD build script

This replaces the use of `/etc/rc.local` in the OpenBSD build script by the sysv init scripts provided with cloud-init.

Fixes GH-4036
LP: #1992853

Additional Context

I've fixed a bug in the sysv init scripts by disabling rc_bg="YES", otherwise it would fail to execute correctly with this error at boot:

rcctl start cloudconfig 
cloudconfig/etc/rc.d/cloudconfig: kill: 66598: No such process
(ok)

Also, /etc/rc.local is not needed anymore, /var/run is managed by the system and does not have to be cleaned up manually.

Test Steps

My own CI: https://github.com/hcartiaux/openbsd-cloud-image/actions/

  • Generate an OpenBSD 7.6 image with cloud-init 24.3.1
  • Apply the diff with the post-install script install.site
  • Generate a minimal iso with a ssh key
  • Boot the previously generated image and wait until the VM is back

I've also tested manually to have a closer look at the output.

Merge type

  • Squash merge using "Proposed Commit Message"
  • Rebase and merge unique commits. Requires commit messages per-commit each referencing the pull request number (#<PR_NUM>)

@holmanb holmanb requested a review from igalic October 7, 2024 15:08
@holmanb
Copy link
Member

holmanb commented Oct 7, 2024

@igalic could you take a look at this please?

@hcartiaux
Copy link
Contributor Author

@holmanb I fear @igalic is not available at the moment, she's not active on github for quite a few weeks with the status "dnd". Anybody else could review? Thanks.

Copy link
Member

@TheRealFalcon TheRealFalcon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @hcartiaux ! The changes look reasonable, and I see the link showing the passing build results.

@TheRealFalcon TheRealFalcon merged commit a911b5e into canonical:main Oct 21, 2024
21 checks passed
holmanb pushed a commit to holmanb/cloud-init that referenced this pull request Oct 22, 2024
…ical#5790)

This replaces the use of `/etc/rc.local` in the OpenBSD build script
by the sysv init scripts provided with cloud-init.

Fixes canonicalGH-4036
LP: #1992853
netcho pushed a commit to storpool/cloud-init that referenced this pull request Oct 24, 2024
…ical#5790)

This replaces the use of `/etc/rc.local` in the OpenBSD build script
by the sysv init scripts provided with cloud-init.

Fixes canonicalGH-4036
LP: #1992853
TheRealFalcon pushed a commit that referenced this pull request Nov 4, 2024
This replaces the use of `/etc/rc.local` in the OpenBSD build script
by the sysv init scripts provided with cloud-init.

Fixes GH-4036
LP: #1992853
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants