-
Notifications
You must be signed in to change notification settings - Fork 881
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: unbreak pytest-xdist #5829
Conversation
'pytest -n auto' fails with random data in parametrization, so work around it.
@@ -267,12 +267,20 @@ def test_main_sys_argv( | |||
# Non-cloud-config | |||
(mock.Mock(), "#!/bin/bash\n - echo hello", True), | |||
# Something that won't decode to utf-8 | |||
(mock.Mock(), os.urandom(100), True), | |||
(mock.Mock(), "RANDOM100", True), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This an the next don't match the comment "won't decode to utf-8".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Push an update
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for fixing this @TheRealFalcon!
'pytest -n auto' fails with random data in parametrization, so work around it.
'pytest -n auto' fails with random data in parametrization, so work around it.
'pytest -n auto' fails with random data in parametrization, so work around it.
Proposed Commit Message
Additional Context
Test Steps
Merge type