Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(gentoo): Add compatibility for Gentoo with systemd #5918

Merged
merged 2 commits into from
Dec 12, 2024

Conversation

akhuettel
Copy link
Contributor

@akhuettel akhuettel commented Dec 7, 2024

  • I have signed the CLA: https://ubuntu.com/legal/contributors
  • I have added my Github username to tools/.github-cla-signers - see Add myself to CLA signers file #5917
  • I have included a comprehensive commit message using the guide below
  • I have added unit tests to cover the new behavior under tests/unittests/
  • I have kept the change small, avoiding unnecessary whitespace or non-functional changes.
  • I have updated the documentation with the changed behavior. (?)

Proposed Commit Message

feat(gentoo): Add compatibility for Gentoo with systemd

Merge type

Rebase please

@akhuettel
Copy link
Contributor Author

Should be fine now, in the last force-push I undid some unnecessary changes to the test file.

@akhuettel
Copy link
Contributor Author

I have no clue what the problem with the "Integration tests" is - but I see errors there involving apt, which can't really be relevant to Gentoo? Anyway, if the failure is something real, advice would be appreciated!

@holmanb
Copy link
Member

holmanb commented Dec 11, 2024

tests" is - but I see errors there involving apt, which can't really be relevant to Gentoo? Anyway, if the failure is something real, advice would

@akhuettel I think that this issue was fixed on the tip of main. If you merge the latest this should go away.

Copy link
Member

@holmanb holmanb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution @akhuettel!

@holmanb holmanb merged commit f6075a9 into canonical:main Dec 12, 2024
22 checks passed
holmanb pushed a commit to holmanb/cloud-init that referenced this pull request Feb 11, 2025
holmanb pushed a commit to holmanb/cloud-init that referenced this pull request Feb 11, 2025
holmanb pushed a commit to holmanb/cloud-init that referenced this pull request Feb 11, 2025
holmanb pushed a commit to holmanb/cloud-init that referenced this pull request Feb 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants