testing: Add missing mock to test_vmware.py (SC-348) #982
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheRealFalcon
force-pushed
the
missing-mock
branch
from
bfb704c to
e885c93
Compare
TheRealFalcon
force-pushed
the
missing-mock
branch
from
e885c93 to
49a399e
Compare
TheRealFalcon
changed the title
TheRealFalcon
force-pushed
the
missing-mock
branch
from
49a399e to
7c0dacf
Compare
|
This is weird. I can run the test file in isolation on macOS without issues: $ git log -1 --oneline && \
printf '\n\n' && \
make clean_pyc && \
PYTHONPATH="$(pwd)" python3 -m pytest -v tests/unittests/test_datasource/test_vmware.py
0bf8d575 (HEAD -> main, upstream/main) add Zadara Edge Cloud Platform to the supported clouds list (#963)
========================================================================================================= test session starts =========================================================================================================
platform darwin -- Python 3.9.6, pytest-6.2.4, py-1.10.0, pluggy-0.13.1 -- /usr/local/opt/python@3.9/bin/python3.9
cachedir: .pytest_cache
rootdir: /Users/akutz/Projects/cloud-init, configfile: tox.ini
collected 23 items
tests/unittests/test_datasource/test_vmware.py::TestDataSourceVMware::test_get_host_info PASSED [ 4%]
tests/unittests/test_datasource/test_vmware.py::TestDataSourceVMware::test_no_data_access_method PASSED [ 8%]
tests/unittests/test_datasource/test_vmware.py::TestDataSourceVMwareEnvVars::test_get_data_metadata_b64 PASSED [ 13%]
tests/unittests/test_datasource/test_vmware.py::TestDataSourceVMwareEnvVars::test_get_data_metadata_base64 PASSED [ 17%]
tests/unittests/test_datasource/test_vmware.py::TestDataSourceVMwareEnvVars::test_get_data_metadata_gz_b64 PASSED [ 21%]
tests/unittests/test_datasource/test_vmware.py::TestDataSourceVMwareEnvVars::test_get_data_metadata_gzip_base64 PASSED [ 26%]
tests/unittests/test_datasource/test_vmware.py::TestDataSourceVMwareEnvVars::test_get_data_metadata_only PASSED [ 30%]
tests/unittests/test_datasource/test_vmware.py::TestDataSourceVMwareEnvVars::test_get_data_userdata_only PASSED [ 34%]
tests/unittests/test_datasource/test_vmware.py::TestDataSourceVMwareEnvVars::test_get_data_vendordata_only PASSED [ 39%]
tests/unittests/test_datasource/test_vmware.py::TestDataSourceVMwareEnvVars::test_get_subplatform PASSED [ 43%]
tests/unittests/test_datasource/test_vmware.py::TestDataSourceVMwareEnvVars::test_metadata_multiple_ssh_keys PASSED [ 47%]
tests/unittests/test_datasource/test_vmware.py::TestDataSourceVMwareEnvVars::test_metadata_single_ssh_key PASSED [ 52%]
tests/unittests/test_datasource/test_vmware.py::TestDataSourceVMwareGuestInfo::test_ds_valid_on_vmware_platform PASSED [ 56%]
tests/unittests/test_datasource/test_vmware.py::TestDataSourceVMwareGuestInfo::test_get_data_metadata_b64 PASSED [ 60%]
tests/unittests/test_datasource/test_vmware.py::TestDataSourceVMwareGuestInfo::test_get_data_metadata_base64 PASSED [ 65%]
tests/unittests/test_datasource/test_vmware.py::TestDataSourceVMwareGuestInfo::test_get_data_metadata_gz_b64 PASSED [ 69%]
tests/unittests/test_datasource/test_vmware.py::TestDataSourceVMwareGuestInfo::test_get_data_metadata_gzip_base64 PASSED [ 73%]
tests/unittests/test_datasource/test_vmware.py::TestDataSourceVMwareGuestInfo::test_get_data_userdata_only PASSED [ 78%]
tests/unittests/test_datasource/test_vmware.py::TestDataSourceVMwareGuestInfo::test_get_data_vendordata_only PASSED [ 82%]
tests/unittests/test_datasource/test_vmware.py::TestDataSourceVMwareGuestInfo::test_get_subplatform PASSED [ 86%]
tests/unittests/test_datasource/test_vmware.py::TestDataSourceVMwareGuestInfo::test_metadata_multiple_ssh_keys PASSED [ 91%]
tests/unittests/test_datasource/test_vmware.py::TestDataSourceVMwareGuestInfo::test_metadata_single_ssh_key PASSED [ 95%]
tests/unittests/test_datasource/test_vmware.py::TestDataSourceVMwareGuestInfo_InvalidPlatform::test_ds_invalid_on_non_vmware_platform PASSED [100%]
========================================================================================================== warnings summary ===========================================================================================================
../../../../usr/local/lib/python3.9/site-packages/_pytest/config/__init__.py:1183
/usr/local/lib/python3.9/site-packages/_pytest/config/__init__.py:1183: PytestDeprecationWarning: The --strict option is deprecated, use --strict-markers instead.
self.issue_config_time_warning(
conftest.py:68
/Users/akutz/Projects/cloud-init/conftest.py:68: PytestDeprecationWarning: @pytest.yield_fixture is deprecated.
Use @pytest.fixture instead; they are the same.
@pytest.yield_fixture(autouse=True)
conftest.py:169
/Users/akutz/Projects/cloud-init/conftest.py:169: PytestDeprecationWarning: @pytest.yield_fixture is deprecated.
Use @pytest.fixture instead; they are the same.
def httpretty():
-- Docs: https://docs.pytest.org/en/stable/warnings.html
=================================================================================================== 23 passed, 3 warnings in 0.53s ==================================================================================================== |
|
What is stranger is it passes in isolation in an Ubuntu container as well: $ cat /etc/os-release && \
echo && \
git log -1 --oneline && \
echo && \
make clean_pyc && \
PYTHONPATH="$(pwd)" python3 -m pytest -v tests/unittests/test_datasource/test_vmware.py
NAME="Ubuntu"
VERSION="20.04.2 LTS (Focal Fossa)"
ID=ubuntu
ID_LIKE=debian
PRETTY_NAME="Ubuntu 20.04.2 LTS"
VERSION_ID="20.04"
HOME_URL="https://www.ubuntu.com/"
SUPPORT_URL="https://help.ubuntu.com/"
BUG_REPORT_URL="https://bugs.launchpad.net/ubuntu/"
PRIVACY_POLICY_URL="https://www.ubuntu.com/legal/terms-and-policies/privacy-policy"
VERSION_CODENAME=focal
UBUNTU_CODENAME=focal
0bf8d575 (HEAD -> main, upstream/main) add Zadara Edge Cloud Platform to the supported clouds list (#963)
========================================================================================================= test session starts =========================================================================================================
platform linux -- Python 3.8.10, pytest-4.6.9, py-1.8.1, pluggy-0.13.0 -- /usr/bin/python3
cachedir: .pytest_cache
rootdir: /usr/local/src/cloud-init, inifile: tox.ini
plugins: cov-2.8.1
collected 23 items
tests/unittests/test_datasource/test_vmware.py::TestDataSourceVMware::test_get_host_info PASSED [ 4%]
tests/unittests/test_datasource/test_vmware.py::TestDataSourceVMware::test_no_data_access_method PASSED [ 8%]
tests/unittests/test_datasource/test_vmware.py::TestDataSourceVMwareEnvVars::test_get_data_metadata_b64 PASSED [ 13%]
tests/unittests/test_datasource/test_vmware.py::TestDataSourceVMwareEnvVars::test_get_data_metadata_base64 PASSED [ 17%]
tests/unittests/test_datasource/test_vmware.py::TestDataSourceVMwareEnvVars::test_get_data_metadata_gz_b64 PASSED [ 21%]
tests/unittests/test_datasource/test_vmware.py::TestDataSourceVMwareEnvVars::test_get_data_metadata_gzip_base64 PASSED [ 26%]
tests/unittests/test_datasource/test_vmware.py::TestDataSourceVMwareEnvVars::test_get_data_metadata_only PASSED [ 30%]
tests/unittests/test_datasource/test_vmware.py::TestDataSourceVMwareEnvVars::test_get_data_userdata_only PASSED [ 34%]
tests/unittests/test_datasource/test_vmware.py::TestDataSourceVMwareEnvVars::test_get_data_vendordata_only PASSED [ 39%]
tests/unittests/test_datasource/test_vmware.py::TestDataSourceVMwareEnvVars::test_get_subplatform PASSED [ 43%]
tests/unittests/test_datasource/test_vmware.py::TestDataSourceVMwareEnvVars::test_metadata_multiple_ssh_keys PASSED [ 47%]
tests/unittests/test_datasource/test_vmware.py::TestDataSourceVMwareEnvVars::test_metadata_single_ssh_key PASSED [ 52%]
tests/unittests/test_datasource/test_vmware.py::TestDataSourceVMwareGuestInfo::test_ds_valid_on_vmware_platform PASSED [ 56%]
tests/unittests/test_datasource/test_vmware.py::TestDataSourceVMwareGuestInfo::test_get_data_metadata_b64 PASSED [ 60%]
tests/unittests/test_datasource/test_vmware.py::TestDataSourceVMwareGuestInfo::test_get_data_metadata_base64 PASSED [ 65%]
tests/unittests/test_datasource/test_vmware.py::TestDataSourceVMwareGuestInfo::test_get_data_metadata_gz_b64 PASSED [ 69%]
tests/unittests/test_datasource/test_vmware.py::TestDataSourceVMwareGuestInfo::test_get_data_metadata_gzip_base64 PASSED [ 73%]
tests/unittests/test_datasource/test_vmware.py::TestDataSourceVMwareGuestInfo::test_get_data_userdata_only PASSED [ 78%]
tests/unittests/test_datasource/test_vmware.py::TestDataSourceVMwareGuestInfo::test_get_data_vendordata_only PASSED [ 82%]
tests/unittests/test_datasource/test_vmware.py::TestDataSourceVMwareGuestInfo::test_get_subplatform PASSED [ 86%]
tests/unittests/test_datasource/test_vmware.py::TestDataSourceVMwareGuestInfo::test_metadata_multiple_ssh_keys PASSED [ 91%]
tests/unittests/test_datasource/test_vmware.py::TestDataSourceVMwareGuestInfo::test_metadata_single_ssh_key PASSED [ 95%]
tests/unittests/test_datasource/test_vmware.py::TestDataSourceVMwareGuestInfo_InvalidPlatform::test_ds_invalid_on_non_vmware_platform PASSED [100%]
====================================================================================================== 23 passed in 0.61 seconds ====================================================================================================== |
blackboxsw
approved these changes
Aug 19, 2021
This was referenced May 12, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additional Context
Running
test_vmware.pyin isolation (or on an rpm-based system) will cause errors due to some missing mocks.Checklist: