disable k8s node cleanup and let CAPI handle it #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bschimke95
force-pushed
the
KU-1176/make-k8s-node-removal-customaziable
branch
from
75f4d68 to
8d91c63
Compare
neoaggelos
approved these changes
Aug 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request addresses an issue where nodes are not properly drained in Cluster API before upgrades. The current CK8s remove hook removes the node from the Kubernetes cluster, which conflicts with the CAPI core controllers responsible for node removal within the CAPI context. As a result, when our controllers remove the node, the core controller loses track and only removes the resource reference in the management cluster.
This PR disables the Kubernetes node removal in the k8s-snap.
Requires canonical/k8s-snap#577 to be merged. See there for more details.