Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow setting the node name in CK8sConfigTemplate #44

Merged
merged 3 commits into from
Aug 20, 2024
Merged

Conversation

neoaggelos
Copy link
Contributor

Summary

Some cloud providers (e.g. AWS) require that the hostname be set to a specific value, typically {{ ds.meta_data.local_hostname }}.

Allow setting this field in the template, and seed this into the generated cloud-init.

Note

{{ ds.meta_data.local_hostname }} will be passed to the cloud-init, then will be replaced with the desired value when Jinja renders it on the local node.

@neoaggelos neoaggelos requested a review from a team as a code owner August 19, 2024 14:56
Copy link
Contributor

@bschimke95 bschimke95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, please fix the go test before merge

@neoaggelos neoaggelos merged commit 6883b5b into main Aug 20, 2024
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants