Use in-place upgrade release annotation if present #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eaudetcobello
approved these changes
Oct 1, 2024
pkg/cloudinit/common.go
Outdated
| type InstallOption string | ||
|
|
||
| const ( | ||
| InstallOptionChannel InstallOption = "track" |
There was a problem hiding this comment.
I'm a bit confused about this part. I can see channel instead of track and localPath instead of local-path.
https://github.com/canonical/cluster-api-k8s/blob/main/pkg/ck8s/workload_cluster.go#L279-L288
If these are the same, maybe we can centralize them?
There was a problem hiding this comment.
I've updated the track mentions to channel. For localPath vs local-path, I've kept local-path to fit the separate with - file naming convention we had. I'll adjust the k8s-snap-api to fit this form with another (cleanup) card I've this pulse.
HomayoonAlimohammadi
approved these changes
Oct 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adjusts the ck8s config reconciler to use the snap install option from an in-place upgrade release annotation if it exists. This can be utilized by adding the release annotation under the
CK8sControlPlaneorMachineDeploymentspecs, which will be propagated down to the machine.For control-plane (CK8sControlPlane)
.spec.machineTemplate.metadata.annotations => Machine.annotationsAdopted something similar to propagation logic from KCP
For workers (MachineDeployment)
.spec.template.metadata.annotations => MachineSet.spec.template.metadata.annotations => Machine.annotations