Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removes resource limit for controlplane manager #94

Merged
merged 1 commit into from
Jan 28, 2025

Conversation

claudiubelu
Copy link
Contributor

Setting a resource limit that is too low may lead to it crashing. Lower resource requests will make it easier for it to be scheduled.

@claudiubelu claudiubelu requested a review from a team as a code owner January 21, 2025 08:57
Copy link
Contributor

@bschimke95 bschimke95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should probably also remove the limits for the k8sd-proxy

Setting a resource limit that is too low may lead to it crashing.
Lower resource requests will make it easier for it to be scheduled.

Signed-off-by: Claudiu Belu <claudiu.belu@canonical.com>
Copy link
Member

@berkayoz berkayoz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@bschimke95 bschimke95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, CI failures are unrelated - merging this.

@bschimke95 bschimke95 merged commit c09ddb2 into canonical:main Jan 28, 2025
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants