Update coredns image tags automatically #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
addyess
force-pushed
the
KU-2129/auto-update-coredns
branch
4 times, most recently
from
22dd765 to
3f8ad8c
Compare
addyess
force-pushed
the
KU-2129/auto-update-coredns
branch
from
3f8ad8c to
a2cc206
Compare
|
See that this PR created #24 |
|
We won't need #18 anymore |
addyess
changed the title
addyess
force-pushed
the
KU-2129/auto-update-coredns
branch
from
6fb5e0b to
d4151a3
Compare
addyess
force-pushed
the
KU-2129/auto-update-coredns
branch
from
9b5156b to
fe35ca7
Compare
addyess
force-pushed
the
KU-2129/auto-update-coredns
branch
from
fe35ca7 to
4b9709e
Compare
HomayoonAlimohammadi
approved these changes
Dec 9, 2024
There was a problem hiding this comment.
Great work, thanks a lot @addyess! Left some minor comments and suggestions. Feel free to ignore them if they seem irrelevant.
| # Target to remove the temporary directory | ||
| clean: | ||
| @rm -rf $(COREDNS_GIT_DIR) | ||
| @echo "Temporary directory removed: $(COREDNS_GIT_DIR)" |
| function usage() { | ||
| if [[ -z ${COREDNS_GIT_DIR+x} ]]; then | ||
| echo "COREDNS_GIT_DIR is not set" > /dev/stderr | ||
| echo " Clone with 'git clone --bare --filter=blob:none --no-checkout https://github.com/coredns/coredns.git /tmp/coredns.git'" > /dev/stderr |
There was a problem hiding this comment.
Suggested change
| echo " Clone with 'git clone --bare --filter=blob:none --no-checkout https://github.com/coredns/coredns.git /tmp/coredns.git'" > /dev/stderr | |
| echo " Clone with 'git clone --bare --filter=blob:none --no-checkout https://github.com/coredns/coredns.git /tmp/coredns.git'" >&2 |
| RO_REPO_DIR=$(dirname ${RO_SCRIPT_DIR}) | ||
| RO_VERSIONS=${RO_SCRIPT_DIR}/../versions.txt | ||
|
|
||
| function usage() { |
There was a problem hiding this comment.
Not really "usage", more of a environment check
| function check_dependencies(){ | ||
| for cmd in yq jq git envsubst; do | ||
| if ! command -v $cmd &> /dev/null; then | ||
| echo "$cmd could not be found" > /dev/stderr |
There was a problem hiding this comment.
Suggested change
| echo "$cmd could not be found" > /dev/stderr | |
| echo "$cmd could not be found" >&2 |
| create_rockcrafts | ||
| } | ||
|
|
||
| main |
|
|
||
| rm -rf ${RO_VERSIONS} | ||
| for rockcraft in $(find ${RO_REPO_DIR} -name 'rockcraft.yaml'); do | ||
| echo $(yq '.version' $rockcraft) >> ${RO_VERSIONS} |
There was a problem hiding this comment.
so? it seems this is required. Without it
yq '.version' $rockcraft >> ${RO_VERSIONS}i get an error:
Error: write /dev/stdout: bad file descriptor
There was a problem hiding this comment.
i think it's due to snap confinement when yq is installed via snap
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
The nightly tests looking for coredns tags upstream should create new rockcraft files based on a template in this repo
Details