Skip to content

Commit

Permalink
fix: review fixes
Browse files Browse the repository at this point in the history
Co-authored-by: Imani Pelton <imani.pelton@canonical.com>
  • Loading branch information
sergiusens and bepri authored Dec 13, 2024
1 parent 34254b3 commit 4077b12
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 2 deletions.
5 changes: 4 additions & 1 deletion tests/integration/test_messages_integration.py
Original file line number Diff line number Diff line change
Expand Up @@ -908,7 +908,10 @@ def test_simple_errors_debugish(capsys, mode):

@pytest.mark.parametrize("output_is_terminal", [True, False])
def test_error_api_details_quiet(capsys):
"""Somewhat expected API error, final user modes."""
"""Somewhat expected API error, final user modes.
Check that "quiet" is indeed quiet.
"""
emit = Emitter()
emit.init(EmitterMode.QUIET, "testapp", GREETING)
full_error = {"message": "Invalid channel.", "code": "BAD-CHANNEL"}
Expand Down
5 changes: 4 additions & 1 deletion tests/unit/test_messages_emitter.py
Original file line number Diff line number Diff line change
Expand Up @@ -878,7 +878,10 @@ def test_reporterror_simple_message_developer_modes(mode, get_initiated_emitter)


def test_reporterror_detailed_info_quiet_modes(get_initiated_emitter):
"""Report an error having detailed information, in final user modes."""
"""Report an error having detailed information, in final user modes.
Check that "quiet" is indeed quiet.
"""
emitter = get_initiated_emitter(EmitterMode.QUIET)
error = CraftError("test message", details="boom")
emitter.error(error)
Expand Down

0 comments on commit 4077b12

Please sign in to comment.