Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The text parameter in Emitter.open_stream() should be optional #188

Closed
tigarmo opened this issue Oct 20, 2023 · 1 comment
Closed

The text parameter in Emitter.open_stream() should be optional #188

tigarmo opened this issue Oct 20, 2023 · 1 comment

Comments

@tigarmo
Copy link
Collaborator

tigarmo commented Oct 20, 2023

What needs to get done

The text parameter in Emitter.open_stream() should be optional

Why it needs to get done

With how the craft apps use the emitter now, the text is often redundant.
@tigarmo
Copy link
Collaborator Author

tigarmo commented Oct 24, 2023

Fixed by #194

@tigarmo tigarmo closed this as completed Oct 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@tigarmo