Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(emit): make text param in open_stream() optional #194

Merged
merged 1 commit into from
Oct 24, 2023
Merged

feat(emit): make text param in open_stream() optional #194

merged 1 commit into from
Oct 24, 2023

Conversation

tigarmo
Copy link
Collaborator

@tigarmo tigarmo commented Oct 23, 2023

  • Have you followed the guidelines for contributing?
  • Have you signed the CLA?
  • Have you successfully run tox?

@codecov
Copy link

codecov bot commented Oct 23, 2023 •
edited
Loading

Codecov Report

Merging #194 (97e2698) into main (aa9e81b) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #194   +/-   ##
=======================================
  Coverage   94.70%   94.70%           
=======================================
  Files           7        7           
  Lines        1057     1058    +1     
  Branches      192      193    +1     
=======================================
+ Hits         1001     1002    +1     
  Misses         53       53           
  Partials        3        3
Files Coverage Δ
craft_cli/messages.py 100.00% <100.00%> (ø)

@tigarmo tigarmo marked this pull request as ready for review October 23, 2023 21:33
@tigarmo tigarmo requested a review from a team October 23, 2023 21:33
@lengau lengau merged commit 24cf0fb into main Oct 24, 2023
8 checks passed
@tigarmo tigarmo deleted the CRAFT-2178-optional-text-stream branch October 24, 2023 13:01
@tigarmo tigarmo mentioned this pull request Oct 24, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lengau lengau lengau approved these changes

@sergiusens sergiusens sergiusens approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tigarmo @sergiusens @lengau