Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

In "streaming brief" mode, emit.message() should clean the progress prefix #202

Closed
tigarmo opened this issue Nov 10, 2023 · 0 comments · Fixed by #203
Closed

In "streaming brief" mode, emit.message() should clean the progress prefix #202

tigarmo opened this issue Nov 10, 2023 · 0 comments · Fixed by #203

Comments

@tigarmo
Copy link
Collaborator

tigarmo commented Nov 10, 2023

Bug Description

If I call emit.progress("Hi") and then emit.message("Done!"), the text that is actually shown is Hi :: Done!.

To Reproduce

Something like:

emit.progress("Hi", permanent=False)
emit.message("Done!")

part yaml

n/a

Relevant log output

n/a
tigarmo added a commit that referenced this issue Nov 16, 2023
@tigarmo
fix: clear prefix for message() and error()
917fa5f 
This affects the "streaming brief" feature: the latest progress()
message is used as a prefix for incoming text, but this must be cleared
for "special", important text like message() and error().

Fixes #202
@tigarmo tigarmo mentioned this issue Nov 16, 2023
Merged
sergiusens pushed a commit that referenced this issue Nov 17, 2023
@tigarmo @sergiusens
fix: clear prefix for message() and error()
256d8c2 
This affects the "streaming brief" feature: the latest progress()
message is used as a prefix for incoming text, but this must be cleared
for "special", important text like message() and error().

Fixes #202
@mr-cal mr-cal mentioned this issue Apr 12, 2024
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: clear prefix for message() and error() canonical/craft-cli
1 participant
@tigarmo