messages: support appdirs user_log_dir for darwin #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
appdirs.user_log_dir takes appname as the first parameter and while
the code path works when it is None for windows and linux, it runs
`os.path.expandpath("~/...", appname)` and darwin which fails as
appname is None.
https://github.com/ActiveState/appdirs/blob/48357882e5c095003e10f8351b405bf54e41424f/appdirs.py#L395
Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com>
sergiusens
force-pushed
the
appdirs-darwin
branch
from
cdb6f58 to
26ebe16
Compare
cmatsuoka
approved these changes
Oct 18, 2021
tigarmo
pushed a commit
that referenced
this pull request
Jun 6, 2023
chore(deps): update release-drafter/release-drafter action to v5.22.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
appdirs.user_log_dir takes appname as the first parameter and while
the code path works when it is None for windows and linux, it runs
os.path.expandpath("~/...", appname)and darwin which fails asappname is None.
https://github.com/ActiveState/appdirs/blob/48357882e5c095003e10f8351b405bf54e41424f/appdirs.py#L395
Signed-off-by: Sergio Schvezov sergio.schvezov@canonical.com