Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: allow the application to choose the help order of commands #196

Merged
merged 3 commits into from
Oct 24, 2023
Merged

feat: allow the application to choose the help order of commands #196

merged 3 commits into from
Oct 24, 2023

Conversation

lengau
Copy link
Contributor

@lengau lengau commented Oct 24, 2023

fixes #195

  • Have you followed the guidelines for contributing?
  • Have you signed the CLA?
  • Have you successfully run tox?

@lengau lengau requested review from cmatsuoka and tigarmo October 24, 2023 15:24
@codecov
Copy link

codecov bot commented Oct 24, 2023 •
edited
Loading

Codecov Report

Merging #196 (1628ccf) into main (19f933e) will increase coverage by 0.02%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #196      +/-   ##
==========================================
+ Coverage   94.70%   94.73%   +0.02%     
==========================================
  Files           7        7              
  Lines        1058     1063       +5     
  Branches      193      194       +1     
==========================================
+ Hits         1002     1007       +5     
  Misses         53       53              
  Partials        3        3
Files Coverage Δ
craft_cli/dispatcher.py 99.15% <100.00%> (+<0.01%) ⬆️
craft_cli/helptexts.py 98.05% <100.00%> (+0.03%) ⬆️

tigarmo
tigarmo reviewed Oct 24, 2023
View reviewed changes
craft_cli/dispatcher.py Outdated Show resolved Hide resolved
@lengau @tigarmo
Update craft_cli/dispatcher.py
1b44511 
Co-authored-by: Tiago Nobrega <tiago.nobrega@canonical.com>
@lengau lengau requested a review from tigarmo October 24, 2023 15:50
tigarmo
tigarmo approved these changes Oct 24, 2023
View reviewed changes
Copy link
Collaborator

@tigarmo tigarmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@sergiusens
Copy link
Collaborator

your commit message needs to be shorter ;-)

@lengau lengau changed the title feat(help): allow the application to choose the help order of commands feat(help): application-provided command order Oct 24, 2023
@sergiusens sergiusens changed the title feat(help): application-provided command order feat: allow the application to choose the help order of commands Oct 24, 2023
@lengau lengau merged commit a88b353 into main Oct 24, 2023
8 checks passed
@lengau lengau deleted the 195-order-commands branch October 24, 2023 21:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tigarmo tigarmo tigarmo approved these changes

@cmatsuoka cmatsuoka Awaiting requested review from cmatsuoka

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow the application to choose the order of commands within a command group
3 participants
@lengau @sergiusens @tigarmo