Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): drop Pydantic dependency #207

Merged
merged 1 commit into from
Nov 29, 2023
Merged

chore(deps): drop Pydantic dependency #207

merged 1 commit into from
Nov 29, 2023

Conversation

tigarmo
Copy link
Collaborator

@tigarmo tigarmo commented Nov 29, 2023

We don't use the library at all - probably what happened is that we copied the deps from somewhere else.

Fixes #201

  • Have you followed the guidelines for contributing?
  • Have you signed the CLA?
  • Have you successfully run tox?

We don't use the library at all - probably what happened is that we
copied the deps from somewhere else.

Fixes #201
Copy link

codecov bot commented Nov 29, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (8332b8f) 94.76% compared to head (1e6ac81) 94.76%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #207   +/-   ##
=======================================
  Coverage   94.76%   94.76%           
=======================================
  Files           7        7           
  Lines        1070     1070           
  Branches      197      197           
=======================================
  Hits         1014     1014           
  Misses         53       53           
  Partials        3        3           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tigarmo tigarmo requested review from lengau and syu-w November 29, 2023 12:45
@lengau lengau merged commit ce2ee08 into main Nov 29, 2023
10 checks passed
@tigarmo tigarmo deleted the drop-pydantic branch November 29, 2023 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

do we need Pydantic?
3 participants