Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support receiving log messages (which we don't controle when happen) after machinery stopped. #25

Merged
merged 1 commit into from
Oct 22, 2021
Merged

Support receiving log messages (which we don't controle when happen) after machinery stopped. #25

merged 1 commit into from
Oct 22, 2021

Conversation

facundobatista
Copy link
Contributor

  • Have you signed the CLA?

cmatsuoka
cmatsuoka approved these changes Oct 22, 2021
View reviewed changes
Copy link
Contributor

@cmatsuoka cmatsuoka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. It could be worth to add some notes to the code or at least to the commit message explaining why this is important.

@facundobatista facundobatista merged commit 6d77094 into canonical:main Oct 22, 2021
tigarmo pushed a commit that referenced this pull request Jun 6, 2023
@renovate
chore(deps): update patch updates (#25)
4b3781b 
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmatsuoka cmatsuoka cmatsuoka approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@facundobatista @cmatsuoka