feat: support app_config in pre_parse_args() #295
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tigarmo
force-pushed
the
work/CRAFT-3585-command-help-app-config
branch
from
c13ed65 to
c3ec47c
Compare
This lets the commands of a given application access the configuration dict during fill_parser() even when building the help message, like in `app cmd -h`. Of course, this can only be used in cases where the configuration dict contains data that the application already has at pre_parse_args()-time. Fixes #292
tigarmo
force-pushed
the
work/CRAFT-3585-command-help-app-config
branch
from
c3ec47c to
0abec72
Compare
upils
reviewed
Oct 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This lets the commands of a given application access the configuration dict during fill_parser() even when building the help message, like in
app cmd -h. Of course, this can only be used in cases where the configuration dict contains data that the application already has at pre_parse_args()-time.Fixes #292
tox?