fix: only greet once when setting the same mode #301
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With this fix, ``Emitter.set_mode(mode)`` becomes a no-op if the emitter is already at that ``mode``. This scenario can happen, for example, if the Emitter is initialized with a mode and then the Dispatcher sets the same mode during command-line handling.
tigarmo
force-pushed
the
work/CRAFT-3658-set-mode-repeated
branch
from
5cf7bf0 to
a6c0f9b
Compare
bepri
approved these changes
Nov 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this fix,
Emitter.set_mode(mode)becomes a no-op if the emitter is already at thatmode. This scenario can happen, for example, if the Emitter is initialized with a mode and then the Dispatcher sets the same mode during command-line handling.tox?