Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove black #305

Merged
merged 2 commits into from
Dec 4, 2024
Merged

Remove black #305

merged 2 commits into from
Dec 4, 2024

Conversation

sergiusens
Copy link
Collaborator

@sergiusens sergiusens commented Dec 4, 2024

  • Have you followed the guidelines for contributing?
  • Have you signed the CLA?
  • Have you successfully run tox?

The version of black was not supported with Python 3.8, the alternative was to switch to the snap version of black.

The commit affecting pyproject.toml and tox.ini is transposed from canonical/charmcraft@d2b40df and canonical/charmcraft@9583793 with the exception of the ISC ignore in pyproject.toml

The second commit is a result of the ruff formatting

The requested Python version (>=3.8) does not satisfy Python>=3.9 and
black==24.10.0 depends on Python>=3.9, we can conclude that
black==24.10.0 cannot be used.

The following rules have been removed and ignoring them has no effect:
- PT004

Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com>
Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com>
@sergiusens sergiusens added the do-not-squash PR should be merged, not squash-merged label Dec 4, 2024
@sergiusens sergiusens requested review from lengau and tigarmo December 4, 2024 14:23
Copy link
Contributor

@lengau lengau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@lengau lengau merged commit 4837258 into main Dec 4, 2024
12 checks passed
@lengau lengau deleted the remove-black branch December 4, 2024 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-squash PR should be merged, not squash-merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants