Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: hide positional arguments with no help #309

Merged
merged 2 commits into from
Dec 12, 2024

Conversation

sergiusens
Copy link
Collaborator

@sergiusens sergiusens commented Dec 12, 2024

Keep the parsing so they show in the command syntax.

  • Have you followed the guidelines for contributing?
  • Have you signed the CLA?
  • Have you successfully run tox?

Fixes #308

This is not a hotfix as Snapcraft 8.5 is already using the latest release. The only other item since is the backtick removal.

@sergiusens sergiusens force-pushed the work/CRAFT-3780-hide-positional-with-no-help branch from f787591 to 0cd275c Compare December 12, 2024 13:08
Keep the parsing so they show in the command syntax.

Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com>
@sergiusens sergiusens force-pushed the work/CRAFT-3780-hide-positional-with-no-help branch from 0cd275c to 13920c5 Compare December 12, 2024 13:24
Copy link
Contributor

@dariuszd21 dariuszd21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

craft_cli/helptexts.py Show resolved Hide resolved
Copy link
Collaborator

@tigarmo tigarmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you add a changelog entry please

Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com>
@sergiusens sergiusens force-pushed the work/CRAFT-3780-hide-positional-with-no-help branch from b340bf0 to 6ac6d35 Compare December 12, 2024 18:02
Copy link
Collaborator

@tigarmo tigarmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanksss

@tigarmo tigarmo merged commit fcbbcb5 into main Dec 12, 2024
12 checks passed
@tigarmo tigarmo deleted the work/CRAFT-3780-hide-positional-with-no-help branch December 12, 2024 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Craft-cli crashes when rendering positional arguments in help messages
3 participants