Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: enable details except in quiet #313

Merged
merged 2 commits into from
Dec 13, 2024
Merged

Conversation

sergiusens
Copy link
Collaborator

  • Have you followed the guidelines for contributing?
  • Have you signed the CLA?
  • Have you successfully run tox?

Produces:

image

The extra Craft Parts message to be removed in Craft Parts

@sergiusens sergiusens force-pushed the work/CRAFT-3725-enable-details branch from d8af6ec to 2049044 Compare December 13, 2024 14:24
Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com>
@sergiusens sergiusens force-pushed the work/CRAFT-3725-enable-details branch from 2049044 to 34254b3 Compare December 13, 2024 14:36
@sergiusens sergiusens requested review from mr-cal and tigarmo December 13, 2024 14:44
Copy link
Collaborator

@tigarmo tigarmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

Copy link
Contributor

@bepri bepri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a couple nitpicks

tests/integration/test_messages_integration.py Outdated Show resolved Hide resolved
tests/unit/test_messages_emitter.py Outdated Show resolved Hide resolved
Co-authored-by: Imani Pelton <imani.pelton@canonical.com>
@sergiusens sergiusens merged commit 4d78ac3 into main Dec 13, 2024
12 checks passed
@sergiusens sergiusens deleted the work/CRAFT-3725-enable-details branch December 13, 2024 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants