-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add prompt to emitter #315
feat: add prompt to emitter #315
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #315 +/- ##
==========================================
+ Coverage 93.24% 94.56% +1.32%
==========================================
Files 7 7
Lines 1080 1197 +117
Branches 200 242 +42
==========================================
+ Hits 1007 1132 +125
+ Misses 66 59 -7
+ Partials 7 6 -1 ☔ View full report in Codecov by Sentry. |
0da221a
to
78963ce
Compare
Signed-off-by: Dariusz Duda <dariusz.duda@canonical.com>
78963ce
to
4351a07
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Just nitpicks, so I'm approving :)
Signed-off-by: Dariusz Duda <dariusz.duda@canonical.com>
Signed-off-by: Dariusz Duda <dariusz.duda@canonical.com>
Signed-off-by: Dariusz Duda <dariusz.duda@canonical.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks!
tox
?Add a functionality to prompt user for an input.
Additionally with
hide
set toTrue
user may be asked for a secret input.(CRAFT-3739)