Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add prompt to emitter #315

Merged
merged 5 commits into from
Dec 20, 2024

Conversation

dariuszd21
Copy link
Contributor

@dariuszd21 dariuszd21 commented Dec 19, 2024

  • Have you followed the guidelines for contributing?
  • Have you signed the CLA?
  • Have you successfully run tox?

Add a functionality to prompt user for an input.
Additionally with hide set to True user may be asked for a secret input.

(CRAFT-3739)

Copy link

codecov bot commented Dec 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.56%. Comparing base (99394c9) to head (af42b4b).
Report is 65 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #315      +/-   ##
==========================================
+ Coverage   93.24%   94.56%   +1.32%     
==========================================
  Files           7        7              
  Lines        1080     1197     +117     
  Branches      200      242      +42     
==========================================
+ Hits         1007     1132     +125     
+ Misses         66       59       -7     
+ Partials        7        6       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dariuszd21 dariuszd21 force-pushed the work/CRAFT-3739-add-prompting branch 3 times, most recently from 0da221a to 78963ce Compare December 19, 2024 22:45
Signed-off-by: Dariusz Duda <dariusz.duda@canonical.com>
@dariuszd21 dariuszd21 force-pushed the work/CRAFT-3739-add-prompting branch from 78963ce to 4351a07 Compare December 19, 2024 22:48
@dariuszd21 dariuszd21 marked this pull request as ready for review December 19, 2024 22:56
@dariuszd21 dariuszd21 requested review from tigarmo, a team and bepri and removed request for a team December 19, 2024 22:56
Copy link
Contributor

@bepri bepri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Just nitpicks, so I'm approving :)

craft_cli/messages.py Show resolved Hide resolved
craft_cli/messages.py Outdated Show resolved Hide resolved
Signed-off-by: Dariusz Duda <dariusz.duda@canonical.com>
Signed-off-by: Dariusz Duda <dariusz.duda@canonical.com>
Signed-off-by: Dariusz Duda <dariusz.duda@canonical.com>
Copy link
Collaborator

@tigarmo tigarmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@tigarmo tigarmo added the squash label Dec 20, 2024
@tigarmo tigarmo merged commit b598dd8 into canonical:main Dec 20, 2024
12 checks passed
@dariuszd21 dariuszd21 deleted the work/CRAFT-3739-add-prompting branch December 20, 2024 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants