Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: migrate how-tos to their own toctree #325

Merged
merged 4 commits into from
Feb 4, 2025
Merged

docs: migrate how-tos to their own toctree #325

merged 4 commits into from
Feb 4, 2025

Conversation

bepri
Copy link
Contributor

@bepri bepri commented Feb 3, 2025

  • Have you followed the guidelines for contributing?
  • Have you signed the CLA?
  • Have you successfully run tox?

@bepri bepri self-assigned this Feb 3, 2025
@bepri bepri marked this pull request as ready for review February 3, 2025 22:18
jahn-junior
jahn-junior approved these changes Feb 4, 2025
View reviewed changes
Copy link

@jahn-junior jahn-junior left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this!

medubelko
medubelko requested changes Feb 4, 2025
View reviewed changes
Copy link

@medubelko medubelko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the directory name, please use how-to-guides, in alignment with Starbase.

medubelko
medubelko approved these changes Feb 4, 2025
View reviewed changes
Copy link

@medubelko medubelko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for doing this!

@bepri bepri merged commit 3128779 into main Feb 4, 2025
10 of 12 checks passed
@bepri bepri deleted the work/how-to-index/CRAFT-4046 branch February 4, 2025 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@medubelko medubelko medubelko approved these changes

@jahn-junior jahn-junior jahn-junior approved these changes

@tigarmo tigarmo Awaiting requested review from tigarmo

Assignees

@bepri bepri

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bepri @medubelko @jahn-junior