Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Declare public API names #38

Merged
merged 1 commit into from
Nov 29, 2021

Conversation

cjwatson
Copy link
Contributor

mypy --strict enforces these by default.

I'm not sure whether Emitter should be public. It doesn't have an underscore, but it also isn't used by charmcraft - I guess it might be needed to implement test fixtures? I decided to err on the side of strictness and you can always open it up if you want.

  • Have you signed the CLA? (Canonical employee, so not required.)

`mypy --strict` enforces these by default.
@facundobatista
Copy link
Contributor

Hola Colin,

We have mixed feelings about the "publicness" of Emitter. As a name, it's not used from outside (so the PR here is fine, will land it). But it's the "main interface with all the message system", so it's weird to declare it "private".

Thanks for this work!

Copy link
Contributor

@facundobatista facundobatista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@facundobatista facundobatista merged commit a89b2be into canonical:main Nov 29, 2021
tigarmo pushed a commit that referenced this pull request Jun 6, 2023
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants