Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provide a log filepath that complies with our requirements (CRAFT-96). #5

Merged
merged 4 commits into from
Sep 13, 2021
Merged

Provide a log filepath that complies with our requirements (CRAFT-96). #5

merged 4 commits into from
Sep 13, 2021

Conversation

facundobatista
Copy link
Contributor

  • Have you signed the CLA?

sergiusens
sergiusens reviewed Sep 8, 2021
View reviewed changes
craft_cli/messages.py Outdated Show resolved Hide resolved
craft_cli/messages.py Outdated Show resolved Hide resolved
craft_cli/messages.py Outdated Show resolved Hide resolved
craft_cli/messages.py Outdated Show resolved Hide resolved
craft_cli/messages.py Outdated Show resolved Hide resolved
cmatsuoka
cmatsuoka approved these changes Sep 9, 2021
View reviewed changes
Copy link
Contributor

@cmatsuoka cmatsuoka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Facundo, lgtm.

sergiusens
sergiusens approved these changes Sep 9, 2021
View reviewed changes
Copy link
Collaborator

@sergiusens sergiusens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I would prefer for the constant to be public as it is documented.

craft_cli/messages.py Show resolved Hide resolved
craft_cli/messages.py Show resolved Hide resolved
@facundobatista facundobatista merged commit 4a9ab61 into canonical:main Sep 13, 2021
tigarmo pushed a commit that referenced this pull request Jun 6, 2023
@lengau
tools: Make renovate cleaner. (#5)
f676cdc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sergiusens sergiusens sergiusens approved these changes

@cmatsuoka cmatsuoka cmatsuoka approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@facundobatista @cmatsuoka @sergiusens