refactor: adjustments to satisfy linters

craft_providers/executor.py

@@ -136,18 +136,18 @@ def temporarily_pull_file(
                 yield tmp_file
 
     @contextlib.contextmanager
-    def modify_file(
+    def edit_file(
         self,
         *,
         source: pathlib.PurePath,
         missing_ok: bool = False,
         pull_file: bool = True,
-    ) -> Generator[Optional[pathlib.Path], None, None]:
-        """Copy a file from the environment for modification via context manager.
-        Upon exiting the context, the file is pushed back to the environment.
-        If the environment file does not exist, a new file will be created for writing.
+    ) -> Generator[pathlib.Path, None, None]:
+        """Edit a file from the environment for modification via context manager.
 
-        The tememporary file is stored in a temporary path which is cleaned later.
+        A file is pulled from an environment for editing via a context manager. Upon
+        exiting, the file is pushed back to the environment. If the environment file
+        does not exist, a new file will be created.
 
         :param source: Environment file to copy.
         :param missing_ok: Do not raise an error if the file does not exist in the
@@ -157,7 +157,6 @@ def modify_file(
             directory does not exist (and `missing_ok` is False).
         :raises ProviderError: On error copying file content.
         """
-
         # Note: This is a convenience function to cache the pro services state in the
         # environment. However, it may be better to use existing methods to reduce complexity.
         with craft_providers.util.temp_paths.home_temporary_file() as tmp_file:

craft_providers/lxd/lxd_instance.py

@@ -24,8 +24,9 @@
 import shutil
 import subprocess
 import tempfile
-from typing import Any, Dict, Iterable, List, Optional
 import warnings
+from typing import Any, Dict, Iterable, List, Optional
+
 import yaml
 
 from craft_providers import pro
@@ -655,18 +656,17 @@ def enable_pro_service(self, services: Iterable[str]) -> None:
         )
 
     @property
-    def pro_services(self) -> set[str]:
+    def pro_services(self) -> Optional[set[str]]:
         """Get the Pro services enabled on the instance."""
-
         # first check if the services are cached in memory
         if hasattr(self, "_pro_services"):
             return self._pro_services
         # then check the instance state
         try:
-            with self.modify_file(
+            with self.edit_file(
                 source=PRO_SERVICES_YAML,
             ) as temp_state_path:
-                with open(temp_state_path, "r") as fh:
+                with temp_state_path.open("r") as fh:
                     return yaml.safe_load(fh)
 
         except FileNotFoundError:
@@ -675,14 +675,13 @@ def pro_services(self) -> set[str]:
     @pro_services.setter
     def pro_services(self, services: set[str]) -> None:
         """Set the Pro services enabled on the instance."""
-
         self._pro_services = services  # cache the services in memory ...
         # ... and write them to the instance
-        with self.modify_file(
+        with self.edit_file(
             source=PRO_SERVICES_YAML,
             pull_file=False,
         ) as temp_state_path:
-            with open(temp_state_path, "w") as fh:
+            with temp_state_path.open("w") as fh:
                 yaml.safe_dump(set(services), fh)
 
     def install_pro_client(self) -> None: