Changes for 1.20.3 #549
Merged
Changes for 1.20.3 #549
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(cherry picked from commit 0089540)
syu-w
approved these changes
Apr 11, 2024
mr-cal
reviewed
Apr 11, 2024
There was a problem hiding this comment.
What do you think about bumping the compatibility tag to v8?
v7 is used by 1.23, so theoretically someone could create an instance with 1.20.3, upgrade to 1.23.x and the same instance would be reused (which we don't want).
I'm happy to do a compatibility tag bump commit, it's more tedious than it should be and I've gotten pretty quick at it.
Meaning I run |
This is the lowest unused compatibility flag.
lengau
force-pushed
the
1.20-fix-cache-directories
branch
from
54e05a6
to
21f58f8
Compare
|
Thanks @mr-cal - I missed the v7 in 1.23. I've updated to v8 now |
|
Integration test failures are expected on this older branch. The tests are trying to launch 23.04 (lunar), which is no longer supported. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tox?This is ready so we can do a rebase.