fix: handle ill-formed profiles created by older rockcraft #588
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Check if the lxd snap is installed by querying the snapd socket instead of looking for an executable in the path, as lxd can use auto-installer stubs. Co-authored-by: Callahan Kovacs <callahan.kovacs@canonical.com> Signed-off-by: Claudio Matsuoka <claudio.matsuoka@canonical.com>
cmatsuoka
commented
Jun 24, 2024
Older versions of rockcraft may have created a rockcraft lxd project containing a broken default profile. If this is the case, tell the user to delete the project and start over. Signed-off-by: Claudio Matsuoka <claudio.matsuoka@canonical.com>
cmatsuoka
force-pushed
the
work/fix-bogus-lxd-profile
branch
from
d6aaf67
to
8b00682
Compare
Signed-off-by: Claudio Matsuoka <claudio.matsuoka@canonical.com>
Signed-off-by: Claudio Matsuoka <claudio.matsuoka@canonical.com>
cmatsuoka
commented
Jun 24, 2024
| if not devices: | ||
| # Project exists but the default profile is ill-formed, tell the user to | ||
| # delete the project and start over. | ||
| raise LXDError( |
There was a problem hiding this comment.
Unfortunately deleting the broken projects ourselves involves deleting everything the project is using first, and this is too risky to implement without better investigation and careful testing.
There was a problem hiding this comment.
this you be a good scenario to have a test for, aside from that, I generally approve of the appoach
There was a problem hiding this comment.
I agree that this new check should have a test
tigarmo
reviewed
Jun 25, 2024
It's a similar check, but performed on the specific project's default profile instead of the default project default profile. |
tigarmo
force-pushed
the
rockcraft
branch
2 times, most recently
from
27b62e2
to
18ca5f3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Older versions of rockcraft may have created a rockcraft lxd project
containing a broken default profile. If this is the case, tell
the user to delete the project and start over.
tox?