Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

compatible(pytest_plugins/microceph): Remove upper limit on pytest dependency #159

Merged
merged 1 commit into from
Apr 3, 2024

Conversation

@carlcsaposs-canonical carlcsaposs-canonical changed the title Remove upper limit on pytest dependency compatible(pytest_plugins/microceph): Remove upper limit on pytest dependency Mar 25, 2024
Copy link

@paulomach paulomach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't it the case to set lower bound, e.g. >= ?

@carlcsaposs-canonical
Copy link
Contributor Author

carlcsaposs-canonical commented Mar 26, 2024

Isn't it the case to set lower bound, e.g. >= ?

^3.1.2 means >=3.1.2,<4
https://python-poetry.org/docs/dependency-specification/

I could've replaced with >=, but for these dependencies specifically, I don't think a lower bound is necessary (since these plugins are libraries & we want to avoid narrowing version options for applications that use the libraries)

@carlcsaposs-canonical carlcsaposs-canonical merged commit 8334cd8 into main Apr 3, 2024
2 of 3 checks passed
@carlcsaposs-canonical carlcsaposs-canonical deleted the upper-constraint branch April 3, 2024 08:55
carlcsaposs-canonical referenced this pull request in canonical/mysql-router-k8s-operator Apr 5, 2024
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
|
[canonical/data-platform-workflows](https://togithub.com/canonical/data-platform-workflows)
| action | minor | `v13.0.0` -> `v13.1.0` |
|
[pytest-operator-cache](https://togithub.com/canonical/data-platform-workflows)
| integration | minor | `v13.0.0` -> `v13.1.0` |
|
[pytest-operator-groups](https://togithub.com/canonical/data-platform-workflows)
| integration | minor | `v13.0.0` -> `v13.1.0` |

---

### Release Notes

<details>
<summary>canonical/data-platform-workflows
(canonical/data-platform-workflows)</summary>

###
[`v13.1.0`](https://togithub.com/canonical/data-platform-workflows/releases/tag/v13.1.0)

[Compare
Source](https://togithub.com/canonical/data-platform-workflows/compare/v13.0.0...v13.1.0)

##### What's Changed

- compatible(pytest_plugins/microceph): Remove upper limit on pytest
dependency by
[@&#8203;carlcsaposs-canonical](https://togithub.com/carlcsaposs-canonical)
in
[https://github.com/canonical/data-platform-workflows/pull/159](https://togithub.com/canonical/data-platform-workflows/pull/159)

**Full Changelog**:
canonical/data-platform-workflows@v13.0.0...v13.1.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - "after 1am and before 3am every
weekday" in timezone Etc/UTC, Automerge - At any time (no schedule
defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about these
updates again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/canonical/mysql-router-k8s-operator).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4yNjkuMiIsInVwZGF0ZWRJblZlciI6IjM3LjI2OS4yIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants