Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DPE-5642: breaking(build_charm.yaml): Pack on self hosted runners #245

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

DPE-5642: breaking(build_charm.yaml): Pack on self hosted runners #245

wants to merge 9 commits into from

Conversation

dragomirp
Copy link
Contributor

Switch build charm jobs to self-hosted runners

dragomirp
dragomirp commented Oct 22, 2024
View reviewed changes
python/cli/data_platform_workflows_cli/craft_tools/collect_bases.py
Comment on lines +26 to +27
craft.Architecture.X64: ["self-hosted", "linux", "X64", "large", "jammy"],
craft.Architecture.ARM64: ["self-hosted", "linux", "ARM64", "large", "jammy"],
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can probably use other runner sizes.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since charmcraft will spin lxd containers, we can also try using noble.

dragomirp
dragomirp commented Oct 22, 2024
View reviewed changes
.github/workflows/build_charm.yaml
Comment on lines +92 to +93
sudo apt-get update
sudo apt-get install pipx -y
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pipx is missing from the IS runners and packages are not up to date.

@dragomirp
Copy link
Contributor Author

Testen on canonical/postgresql-operator#655 (ccc build) and canonical/pgbouncer-operator#396 (clean build)

Postgresql main self-hosted
Jammy amd64 5m 45s 7m 2s
Jammy arm64 7m 28s 9m 31s
Pgbouncer main self-hosted
Focal amd64 11m 57s 16m 45s
Focal arm64 18m 56s 22m 22s
Jammy amd64 13m 26s 10m 51s
Jammy arm64 17m 53s 17m 18s

@dragomirp dragomirp marked this pull request as ready for review October 22, 2024 21:29
carlcsaposs-canonical
carlcsaposs-canonical reviewed Oct 23, 2024
View reviewed changes
Copy link
Contributor

@carlcsaposs-canonical carlcsaposs-canonical left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we should merge this yet

imo, we should only use this branch on pgbouncer VM as a temporary solution until charmcraftcache is (potentially) refactored, pending outcomes of discussions in Den Haag

@taurus-forever
Copy link

@carlcsaposs-canonical this can wait for the next week discussion.

@taurus-forever taurus-forever changed the title breaking(build_charm.yaml): Pack on self hosted runners DPE-5642: breaking(build_charm.yaml): Pack on self hosted runners Oct 23, 2024
@taurus-forever
Copy link

@carlcsaposs-canonical I believe we are still on the same ground and should start moving to IS runners.
As a first step we can see the pgbouncer VM stability before merging this... what is our plan?

@carlcsaposs-canonical
Copy link
Contributor

@carlcsaposs-canonical I believe we are still on the same ground and should start moving to IS runners. As a first step we can see the pgbouncer VM stability before merging this... what is our plan?

imo, we should only use this branch on pgbouncer VM as a temporary solution until charmcraftcache is refactored

@dragomirp
Copy link
Contributor Author

@carlcsaposs-canonical I believe we are still on the same ground and should start moving to IS runners. As a first step we can see the pgbouncer VM stability before merging this... what is our plan?

imo, we should only use this branch on pgbouncer VM as a temporary solution until charmcraftcache is refactored

Started canonical/pgbouncer-operator#396 to switch PGB

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carlcsaposs-canonical carlcsaposs-canonical carlcsaposs-canonical left review comments

@taurus-forever taurus-forever Awaiting requested review from taurus-forever

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dragomirp @taurus-forever @carlcsaposs-canonical