Address review comments

Signed-off-by: Cole Miller <cole.miller@canonical.com>

src/role_management.c

@@ -36,7 +36,7 @@
  * adjustment if a "tick" occurs while the queue of changes from the last
  * round is still nonempty.
  *
- * A handover is triggered when we call dqlite_node_stop on a node that's
+ * A handover is triggered when we call dqlite_node_handover on a node that's
  * the current cluster leader, or is a voter. Before shutting down for real,
  * the node in question tries to cause another node to become leader (using
  * raft_transfer), if applicable, and then promotes another node to voter
@@ -670,6 +670,7 @@ void RoleManagementAdjust(struct dqlite_node *d)
  if (!QUEUE__IS_EMPTY(&d->changes)) {
  return;
  }
+ assert(d->running);
  pollCluster(d, adjustClusterCb);
 }
 

src/server.h

@@ -30,13 +30,13 @@ struct dqlite_node
  struct raft_uv_transport raft_transport; /* Raft libuv transport */
  struct raft_io raft_io; /* libuv I/O */
  struct raft_fsm raft_fsm; /* dqlite FSM */
- sem_t ready; /* Server is ready */
- sem_t stopped; /* Notify loop stopped */
+ sem_t ready;  /* Server is ready */
+ sem_t stopped;  /* Notify loop stopped */
  sem_t handover_done;
- queue queue;  /* Incoming connections */
- queue conns;  /* Active connections */
+ queue queue; /* Incoming connections */
+ queue conns; /* Active connections */
  queue changes;
- bool running; /* Loop is running */
+ bool running;  /* Loop is running */
  struct raft raft; /* Raft instance */
  struct uv_stream_s *listener; /* Listening socket */
  struct uv_async_s handover;