Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Thread pool clean #598

Merged
merged 2 commits into from
Feb 22, 2024
Merged

Thread pool clean #598

merged 2 commits into from
Feb 22, 2024

Conversation

just-now
Copy link
Contributor

No description provided.

Copy link

codecov bot commented Feb 21, 2024

Codecov Report

Attention: 54 lines in your changes are missing coverage. Please review.

Comparison is base (6134a79) 81.16% compared to head (3da0521) 81.23%.
Report is 2 commits behind head on master.

❗ Current head 3da0521 differs from pull request most recent head 616e1a3. Consider uploading reports for the commit 616e1a3 to get more accurate results

Files Patch % Lines
src/lib/threadpool.c 83.40% 16 Missing and 24 partials ⚠️
src/lib/sm.c 53.33% 0 Missing and 14 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #598      +/-   ##
==========================================
+ Coverage   81.16%   81.23%   +0.06%     
==========================================
  Files         189      191       +2     
  Lines       26742    27028     +286     
  Branches     4859     4919      +60     
==========================================
+ Hits        21704    21955     +251     
+ Misses       3455     3445      -10     
- Partials     1583     1628      +45     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@just-now
Copy link
Contributor Author

src/lib/threadpool.c, line 46, state machine descriptor is just destroyed by clang-format.
The following link is just one symptom of clang-format-related issue:
clangd/clangd#142

Maybe it's worth trying newer version.

@just-now
Copy link
Contributor Author

Seems clang-format-15 with Cpp11BracedListStyle: false gives better results.

Signed-off-by: Anatoliy Bilenko <anatoliy.bilenko@canonical.com>
@cole-miller
Copy link
Contributor

@just-now FYI since #568 merged we now use clang-format 17 in CI

Signed-off-by: Anatoliy Bilenko <anatoliy.bilenko@canonical.com>
@cole-miller cole-miller merged commit c9eda92 into canonical:master Feb 22, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants