Don't check for lz4 unless building raft #603
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cole-miller
force-pushed
the
nolz4
branch
3 times, most recently
from
d686d05
to
8e8c7fa
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #603 +/- ##
==========================================
+ Coverage 81.16% 81.23% +0.06%
==========================================
Files 189 191 +2
Lines 26742 27033 +291
Branches 4859 4933 +74
==========================================
+ Hits 21704 21959 +255
- Misses 3455 3480 +25
- Partials 1583 1594 +11 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Cole Miller <cole.miller@canonical.com>
cole-miller
changed the title
|
This is needed to fix PPA builds |
MathieuBordere
approved these changes
Feb 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now the build is broken when liblz4-dev is not installed and --enable-build-raft is not used. This was an oversight on my part when developing #568.
Signed-off-by: Cole Miller cole.miller@canonical.com